What would you [do/have done]

Karen15

Hello,
Which of the following sentences is correct?
1. If I were your sister, what would you do? (correct)
2. If I were your sister, what would you have done? (incorrect)
It should be "If I had been your sister, what would you have done?"

I think both are correct while expressing different meanings.

Karen151. If I were your sister, what would you do?

What would you do (now) if I were your sister?

Karen152. If I were your sister, what would you have done?

You could never be their sister; time doesn't change anything. But what would you have don

Karen15Which of the following sentences is correct?1. If I were your sister, what would you do?2. If I were your sister, what would you have done?

The first is definitely correct. The second doesn't follow the usual sequence of tenses for a typical conditional, but given that we replace the past perfect with the past in so many other cases, I would conside

If I were your sister, what would you do?

"If I was your sister, what would you do?" - Speaking about a future action.

"If I was your sister, what would you have done?" - Speaking about an alternative action that could have been done in the past.