You may be right, but people aren't always using correct grammar. I tend to think of using "which" when there are a small number of choices. If I showed someone three colors, I'd say "which do you prefer", but it doesn't sound ungrammatical to me to use "what" when given a choice of all the colors.
New words, one handy idiom, and a 2-minute quiz — delivered to your inbox to keep your streak alive.