To ask a person his or her occupation, say "What do you do?"
"What are you?" seems too ambiguous and abrupt. It needs the right context to make sense, for example, after someone says, "I'm a ____."
-- What do you do?
-- I'm an accountant. What are you?
-- I'm a swimming teacher.
Even in the dialog above "What do you do?" would be more appropr