0
Grape cobra Posted 9 years ago
Grammar

Tenses

He thanked me for what I ---.

Is it have done or had done

  

Top answer

If you did it relatively recently and it is still of present relevance, "have done" is preferable. Otherwise, 'had done' is fine. what I did'.

  • If you did it relatively recently and it is still of present relevance, "have done" is preferable.
  • Otherwise, 'had done' is fine.
  • what I did'.
Free · every Monday

Get the Weekly English Kit 📬

New words, one handy idiom, and a 2-minute quiz — delivered to your inbox to keep your streak alive.

2 Answers
0

If you did it relatively recently and it is still of present relevance, "have done" is preferable.

Otherwise, 'had done' is fine.

You could also say '...what I did'.

0

He thanked me for what I had done.

Related Questions