Let's turn it round to begin with the main caluse: She will never know (that) you love her until you tell her (that) you love her . The tenses are fine. In subordinate clauses of time introduced by such words as when, before, after, until, etc.
New words, one handy idiom, and a 2-minute quiz — delivered to your inbox to keep your streak alive.