Should I say:
He has already visited that city before his school trip.
or
He had already visited that city before his school trip.
I think I have heard the first before. In my grammar textbook the second is used.
Zattori He has already visited that city before his school trip. He had already visited that city before his school trip. You can't use the present perfect tense with a before -clause as you have done in the first sentence.
New words, one handy idiom, and a 2-minute quiz — delivered to your inbox to keep your streak alive.
ZattoriHe has already visited that city before his school trip....
He had already visited that city before his school trip.
You can't use the present perfect tense with a before-clause as you have done in the first sentence.
The second sentence is OK.
CJ