The author is trying to make a phrase into an adjective. Using so many dashes is often not serious. It's similar to how writers use quotation marks (scare quotes) not as direct quotations but for irony/sarcasm.
New words, one handy idiom, and a 2-minute quiz — delivered to your inbox to keep your streak alive.